TST check sample_weight shape added to common tests#11598
Merged
thomasjpfan merged 10 commits intoscikit-learn:masterfrom Feb 21, 2020
Merged
TST check sample_weight shape added to common tests#11598thomasjpfan merged 10 commits intoscikit-learn:masterfrom
thomasjpfan merged 10 commits intoscikit-learn:masterfrom
Conversation
rth
approved these changes
Feb 21, 2020
Member
rth
left a comment
There was a problem hiding this comment.
Thanks @sergulaydore and sorry this didn't get much review at the time.
I pushed a few changes to take into account updates in the code base and removed a few checks made redundant by this common check.
thomasjpfan
approved these changes
Feb 21, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for working on this @sergulaydore !
LGTM
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #9926 (Ensure that the shape of sample_weight is checked in all the functions)
What does this implement/fix? Explain your changes.
I added a new check that makes sure an error is raised if the shape of the
sample_weightis different than the sample size. Two estimators were missing the test so I added a test to those estimators.Any other comments?
No