[MRG] Fix collections.abc deprecations with Python 3.7 (0.19.X backport)#11509
Merged
ogrisel merged 7 commits intoscikit-learn:0.19.Xfrom Jul 14, 2018
Merged
[MRG] Fix collections.abc deprecations with Python 3.7 (0.19.X backport)#11509ogrisel merged 7 commits intoscikit-learn:0.19.Xfrom
ogrisel merged 7 commits intoscikit-learn:0.19.Xfrom
Conversation
|
This pull request introduces 9 alerts when merging 94ce03d into baa18ee - view on LGTM.com new alerts:
Comment posted by LGTM.com |
Member
|
there's no pytest on 0.19.2, so you need to fix that, I guess? |
Member
Author
|
Yes, working on it.. |
|
This pull request introduces 8 alerts when merging cc66ffa into baa18ee - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 8 alerts when merging a7a43dd into baa18ee - view on LGTM.com new alerts:
Comment posted by LGTM.com |
Member
|
Thanks, merged. |
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Jul 27, 2018
* tag '0.19.2': Release 0.19.2 [MRG] Fix collections.abc deprecations with Python 3.7 (0.19.X backport) (scikit-learn#11509) FIX need to explicitly raise SkipTest MAINT disabled some tests failing under macOS and 32-bit Python on windows. MNT Release 0.19.2 with python 3.7 support (scikit-learn#11422) DOC previous versions -> all available versions (scikit-learn#10179) MAINT only build versions list on master branch [MRG+1] MAINT Use magic to list documentation versions (scikit-learn#9841) DOC Add Examples heading minor fixes to whatsnew fix release 0.19.1 whatsnew link (scikit-learn#9981)
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Jul 27, 2018
* releases: Release 0.19.2 [MRG] Fix collections.abc deprecations with Python 3.7 (0.19.X backport) (scikit-learn#11509) FIX need to explicitly raise SkipTest MAINT disabled some tests failing under macOS and 32-bit Python on windows. MNT Release 0.19.2 with python 3.7 support (scikit-learn#11422) DOC previous versions -> all available versions (scikit-learn#10179) MAINT only build versions list on master branch [MRG+1] MAINT Use magic to list documentation versions (scikit-learn#9841) DOC Add Examples heading minor fixes to whatsnew fix release 0.19.1 whatsnew link (scikit-learn#9981)
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Jul 27, 2018
* dfsg: Release 0.19.2 [MRG] Fix collections.abc deprecations with Python 3.7 (0.19.X backport) (scikit-learn#11509) FIX need to explicitly raise SkipTest MAINT disabled some tests failing under macOS and 32-bit Python on windows. MNT Release 0.19.2 with python 3.7 support (scikit-learn#11422) DOC previous versions -> all available versions (scikit-learn#10179) MAINT only build versions list on master branch [MRG+1] MAINT Use magic to list documentation versions (scikit-learn#9841) DOC Add Examples heading minor fixes to whatsnew fix release 0.19.1 whatsnew link (scikit-learn#9981)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #11431 to 0.19.X that removes the deprecation warning about ABC being moved from collections to collections.abc when importing scikit-learn in Python 3.7.
Do not merge while the parent PR is not merged.Done as part of #11422