[MRG+1] FIX doctests I broke in merging #11180#11318
Merged
jnothman merged 1 commit intoscikit-learn:masterfrom Jun 20, 2018
Merged
[MRG+1] FIX doctests I broke in merging #11180#11318jnothman merged 1 commit intoscikit-learn:masterfrom
jnothman merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
Author
|
This just skips tests reliant on fetch_mldata, which sometimes fails on CI. |
Member
Author
|
It turns out the issue was having to point the fixtures at index.rst |
qinhanmin2014
approved these changes
Jun 19, 2018
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
LGTM, though I'm wondering whether we need to add or is_index everywhere (seems that only adding it to setup_mldata() is enough?)
This was referenced Jun 19, 2018
Member
Author
|
I think we're best off just keeping it working the way it used to. |
georgipeev
pushed a commit
to georgipeev/scikit-learn
that referenced
this pull request
Jun 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking for a green tick