[MRG] Document length_scale_bounds="fixed" in GP kernels #8358#11274
Closed
elainejiang8 wants to merge 2 commits intoscikit-learn:masterfrom
Closed
[MRG] Document length_scale_bounds="fixed" in GP kernels #8358#11274elainejiang8 wants to merge 2 commits intoscikit-learn:masterfrom
length_scale_bounds="fixed" in GP kernels #8358#11274elainejiang8 wants to merge 2 commits intoscikit-learn:masterfrom
Conversation
Member
|
Sorry for the very slow reply. Doesn't the same comment apply to other |
Member
Yes, according to the docstring at the top of the file it should. @elainejiang8, can you update the other parameters docstrings as well? |
Member
|
Finished in #16209. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #8358. See also PR #8391.
What does this implement/fix? Explain your changes.
Documents more clearly that if length_scale_bounds is set to "fixed", the hyperparameter length_scale cannot be changed during tuning.
Any other comments?
Put the default values in the description line as suggested here https://github.com/scikit-learn/scikit-learn/pull/8391/files, since adding default values to the type specification line exceeds the maximum line limit.