[MRG] Document length_scale_bounds="fixed" in GP kernels #8358#8391
[MRG] Document length_scale_bounds="fixed" in GP kernels #8358#8391Neurrone wants to merge 4 commits intoscikit-learn:masterfrom
length_scale_bounds="fixed" in GP kernels #8358#8391Conversation
|
Ready for review. If the wording's OK, will replicate this in the other classes. |
Codecov Report
@@ Coverage Diff @@
## master #8391 +/- ##
=======================================
Coverage 94.75% 94.75%
=======================================
Files 342 342
Lines 60813 60813
=======================================
Hits 57621 57621
Misses 3192 3192
Continue to review full report at Codecov.
|
…stances of length_scale_bounds
|
@jnothman changes made. |
jnothman
left a comment
There was a problem hiding this comment.
Doesn't the same comment apply to other _bounds
parameters?
| length_scale_bounds : pair of floats >= 0, default: (1e-5, 1e5) | ||
| The lower and upper bound on length_scale | ||
| length_scale_bounds : pair of floats >= 0 or the string "fixed", | ||
| default: (1e-5, 1e5) |
There was a problem hiding this comment.
This won't appear as part of the type specification, but as part of the description. See http://scikit-learn.org/circle?8956/_changed.html.
Instead do "The lower and upper bound on length_scale (default: (1e-5, 1e5))."
|
lgtm pending @jnothman's comments. |
|
@Neurrone are you still working on this? |
|
@amueller sorry, no. |
|
Thanks for the update we'll open up for contributions! |
Reference Issue
Fixes #8358
What does this implement/fix? Explain your changes.
Document length_scale_bounds = "fixed" in GP kernels.