Compatibility with python 3.7.0b5 #11224#11256
Merged
ogrisel merged 3 commits intoscikit-learn:masterfrom Jun 14, 2018
wenhaoz-fengcai:master
Merged
Compatibility with python 3.7.0b5 #11224#11256ogrisel merged 3 commits intoscikit-learn:masterfrom wenhaoz-fengcai:master
ogrisel merged 3 commits intoscikit-learn:masterfrom
wenhaoz-fengcai:master
Conversation
Member
|
LGTM, thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #11224
Issue: Compatibility with Python 3.7.0b5
What does this implement/fix? Explain your changes.
In sklearn/exceptions.py, replace trailing comma , at line 33 and 124 with doctest's ELLIPSIS.
Any other comments?
Modified code passed the test suite and is ready to merge.