MAINT: fix to enable Cython 0.28 to build extended_mutual_info.pyx#10851
Conversation
jnothman
left a comment
There was a problem hiding this comment.
Perhaps we should also increase CYTHON_VERSION in Travis
|
Interesting, I can compile fine with cython 0.28.1 and the Travis Cron job is testing cython-dev and is not failing either. Do you actually get a compilation error? Is that with the Intel Compiler? What this PR does for me is get rid of this warning during compilation: Getting rid of the warning seems like a good enough reason to merge this. |
|
Yes, we've had this warning noted before... I just can't remember where now.
…On 22 March 2018 at 10:08, Loïc Estève ***@***.***> wrote:
Interesting, I can compile fine with cython 0.28.1 and the Travis Cron job
is testing cython-dev and is not failing either. Do you actually get a
compilation error? Is that with the Intel Compiler?
What this PR does for me is get rid of this warning during compilation:
Warning: Subpackage 'sklearn.metrics/cluster' configuration returned as 'sklearn.metrics.cluster'
Getting rid of the warning seems like a good enough reason to merge this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#10851 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6yxi2x7T8ZrZ-oCPkgPAs8tiYcsGks5tgt1TgaJpZM4S2BOp>
.
|
|
@lesteve Yes, I encountered the failure while using Intel Compiler. |
|
pretty sure I fixed that error... but maybe that never landed in master? Which version did you try to compile @oleksandr-pavlyk ? |
|
Errors occurred while compiling 0.19.1. Trying to compile master, errors were gone, but the Cython warning indicated that not all of it got fixed, which is why I decided to propose this change. |
|
makes sense. |
With update of Cython from 0.27.3 to 0.28 compiling cythonized source of
extended_mutual_info.pyxin 1.0.0 sources started failing with the error that the module with namesklearn.metrics/cluster.in it could not be found.Applying the proposed fix allowed the compilation to proceed as expected.