Skip to content

[MRG] contours is no kwarg of matplotlib.pyplot.contour#10569

Merged
lesteve merged 1 commit intoscikit-learn:masterfrom
jotasi:remove_unknown_keyword
Feb 1, 2018
Merged

[MRG] contours is no kwarg of matplotlib.pyplot.contour#10569
lesteve merged 1 commit intoscikit-learn:masterfrom
jotasi:remove_unknown_keyword

Conversation

@jotasi
Copy link
Copy Markdown

@jotasi jotasi commented Feb 1, 2018

Reference Issues/PRs

See discussion of #10527

What does this implement/fix? Explain your changes.

The examples plot_face_segmentation.py and plot_face_ward_segmentation.py raise the warning:
matplotlib/contour.py:967: UserWarning: The following kwargs were not used by contour: 'contours' as matplotlib.pyplot.contour is called with the kwarg contours, which is not part of its API (neither for version 1.3 nor for the current version 2.1.1) and is thus removed here.

@lesteve
Copy link
Copy Markdown
Member

lesteve commented Feb 1, 2018

I double-checked the generated doc and compared to the dev docs and everything looks exactly the same. Merging, thanks a lot @jotasi.

@lesteve lesteve merged commit b846467 into scikit-learn:master Feb 1, 2018
lesteve added a commit that referenced this pull request Feb 2, 2018
@jotasi jotasi deleted the remove_unknown_keyword branch February 15, 2018 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants