Bradley Thresholding added#919
Bradley Thresholding added#919mailjenil wants to merge 2 commits intoscikit-image:masterfrom mailjenil:brad
Conversation
skimage/filter/thresholding.py
Outdated
There was a problem hiding this comment.
There seems to be an unnecessary indent
|
in the future running the build on your own machine would help before submitting a pull request ;), you just forgot quite a few imports here. |
There was a problem hiding this comment.
your indent for all of these is wrong. remember tab = 4 spaces, if you use vim this is expandtab=4, either way you should be able to set this on most text/code editors.
|
@stefanv @RONNCC @vighneshbirodkar Thanks a lot for reviewing the code and pointing out obvious bugs in it. It was my first contribution to scikit-image and so did a lot of blunders. I will fix them as soon as possible. |
|
@mailjenil Everyone's PRs have comments! There's no shame in it, just a learning experience. Thanks for the PR! |
|
@JDWarner Learning is the best part of contribution I believe. However, which editor will you recommend for PEP8 guidelines? I am currently using 'Geany' but missed out on PEP8 plugin part. |
|
There are various editor preferences and I don't want to start a war, but for what it's worth... My personal preference - and I believe it is an excellent option - is Sublime Text. You can configure it to eliminate trailing whitespace on save, but for automatic PEP8 checking you can install the "flake8" package. I believe there's even an "autopep8" package which you can configure to run on save and fix errors automatically. That doesn't always work perfectly, though, so I prefer to have them flagged as I type and fix them manually. Over time it's better at encouraging best practices, as well. You can set similar things up with other editors as well. |
|
@JDWarner Thanks for the guidance.I will check it out and see whether it works for me. |
|
@mailjenil no matter how skilled of a coder you are, you'll probably have a comment somewhere :), code reviews are a hallmark of coding. In the future running it on your own machine before pulling might help, I also have import errors sometimes haha |
|
Travis is failing. |
|
Any update on this? |
|
I will soon fix it..
|
|
@mailjenil ping. |
|
This PR is now more than 6 months overdue. Closing unless there is further discussion. |
|
Will sort it out in few days. Probably next weekend.
|
|
Assigned to myself. I'll try to push it to the end. |
Hello all,
I have implemented Bradley Thresholding algorithm as cited in Adaptive Thresholding Using the Integral Image.(http://people.scs.carleton.ca/~roth/iit-publications-iti/docs/gerh-50002.pdf)