Use src layout and create skimage2 directory#7864
Merged
lagru merged 45 commits intoscikit-image:mainfrom Aug 15, 2025
Merged
Conversation
Contributor
|
The doc test fails because of lack of matplotlib |
6873d19 to
a807a76
Compare
a807a76 to
e897593
Compare
37be658 to
aa7745b
Compare
21ff343 to
a79cdc2
Compare
- Use unique test prefixes - Avoid relative imports - Do not import from other tests
I'm not exactly sure why this is necessary to catch "skimage" too. Maybe some part of the implementation raises the warning internally and doesn't catch it. At the worst, this means users might see a warning twice. I don't really care enough to investigate because we are removing the whole thing.
This reverts commit 253364e.
Co-authored-by: Grzegorz Bokota <bokota@gmail.com>
Czaki
reviewed
Aug 15, 2025
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Member
|
It looks like that's a longer fix. We'll merge for now and will address the wheel building in another PR. |
stefanv
added a commit
that referenced
this pull request
Aug 15, 2025
--------- Co-authored-by: Stefan van der Walt <stefanv@berkeley.edu> Co-authored-by: Lars Grüter <lagru@mailbox.org> Co-authored-by: Grzegorz Bokota <bokota@gmail.com> Co-authored-by: Stefan van der Walt <stefan@mentat.za.net> Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
stefanv
added a commit
that referenced
this pull request
Jan 31, 2026
The changes in #7864 would include `--pyargs skimage` even if in cases such as ``` spin test -- tests/skimage/... ``` which don't indicate that doctests should be run too. This fix makes sure to only add `--pyargs` if the user doesn't give any indication which tests are to be run in the form of positional arguments. --------- Co-authored-by: Stefan van der Walt <sjvdwalt@gmail.com> Co-authored-by: Matthew Brett <matthew.brett@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per our discussion at the in-person sprint, let's go for the
srclayout and get started with theskimage2namespace./cc @lagru @stefanv @jni @matthew-brett @Czaki
Checklist
./doc/examplesfor new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.