Cut down runtime of rolling-ball gallery example.#7705
Merged
mkcor merged 12 commits intoscikit-image:mainfrom Mar 7, 2025
Merged
Cut down runtime of rolling-ball gallery example.#7705mkcor merged 12 commits intoscikit-image:mainfrom
mkcor merged 12 commits intoscikit-image:mainfrom
Conversation
mkcor
commented
Feb 18, 2025
| background2 = restoration.rolling_ball(x, radius=10) | ||
| background = ski.restoration.rolling_ball(x, radius=80) | ||
| background2 = ski.restoration.rolling_ball(x, radius=10) | ||
| plt.figure() |
Member
Author
There was a problem hiding this comment.
Should update to Matplotlib's OO style here.
Member
There was a problem hiding this comment.
If you feel like it, but orthogonal to the issue I think. :)
Member
Author
There was a problem hiding this comment.
Yes, totally orthogonal to this PR! I meant, it should be addressed in a different PR. In #7531, @GParolini took care of this for a few examples in doc/examples/segmentation but not all of them.
Co-authored-by: Stefan van der Walt <stefanv@berkeley.edu>
Member
Author
It's happening here 071768d; in the PR description I linked to the exploration I did with |
Co-authored-by: Stefan van der Walt <stefan@mentat.za.net>
mkcor
commented
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR follows up on #7682.
Closes #7680.
Checklist
./doc/examplesfor new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.