Use matplotlib oo-style in examples#7531
Merged
jarrodmillman merged 13 commits intoscikit-image:mainfrom Feb 27, 2025
Merged
Conversation
Member
lagru
reviewed
Dec 17, 2024
Member
|
The |
mkcor
approved these changes
Jan 8, 2025
Member
|
@GParolini all CI checks are passing! We're almost there! 🎉 Do you mind addressing the one minor suggestion I left? Thanks! 🙏 |
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
stefanv
reviewed
Feb 27, 2025
|
|
||
| def make_ax(grid=False): | ||
| ax = plt.figure().add_subplot(projection='3d') | ||
| fig, ax = plt.subplots(subplot_kw={'projection': '3d'}) |
Member
There was a problem hiding this comment.
Just checking if this is a newer syntax?
Member
|
I think we can merge this. The 3d setup is not important, I was just curious. Thanks @GParolini! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Release note