Port testing on Windows from Azure CI to GitHub's CI#7687
Port testing on Windows from Azure CI to GitHub's CI#7687lagru merged 10 commits intoscikit-image:mainfrom
Conversation
3e0d28b to
a37be10
Compare
matthew-brett
left a comment
There was a problem hiding this comment.
Some perhaps-helpful questions.
|
All good with me. |
.github/workflows/tests-windows.yaml
Outdated
| - name: Run tests | ||
| shell: bash | ||
| run: | | ||
| (cd .. && pytest --doctest-plus --showlocals --pyargs skimage) |
There was a problem hiding this comment.
From the CI's output it seems like we need
PYTEST: "pytest --config-file ${{ github.workspace }}/pyproject.toml"
here as well?
There was a problem hiding this comment.
Yes, correct; started this branch before that one was merged.
| # and stop further segmentation. | ||
| # | ||
| # It may make sense to a warning here; on the other hand segmentations | ||
| # are not a ground truth, so this level of "noise" should be acceptable. |
There was a problem hiding this comment.
I might be confused here but I think the _label_all(rag, 'ncut label') should be indented as well and the comment above updated? Otherwise it's confusing because the body of the if-statement now executes for the non-degenerate case?
There was a problem hiding this comment.
The body of the if statement runs for the non-degenerate case, yes. The comment is to explain why the if-clause is necessary in the first place. We could move it around, to make it clearer.
lagru
left a comment
There was a problem hiding this comment.
Only two comments left, should be good to go then IMO.
Assign the unique "ncut label" to the last remaining pixels, or in the degenerate case (typically 3 pixels).
61beb6f to
b49ddf8
Compare
lagru
left a comment
There was a problem hiding this comment.
Thanks everyone. Looks perfect. Really excited for the brave new "10 min"-CI world. 🥰
…ailure * origin/main: Add zizmor to pre-commit; address GH workflow issues raised (scikit-image#7662) Reenable test marked as flaky on Azure. (scikit-image#7694) Simultaneously resolve all dependencies; add pip caching (scikit-image#7690) Copy keypoints if necessary to preserve contiguity (scikit-image#7692) CI cleanup (scikit-image#7693) Port CI testing from Azure to GitHub (scikit-image#7687) Lower CI build verbosity Use pytest config in pyproject.toml in CI (scikit-image#7555) Improve docstring for rolling_ball function. (scikit-image#7682)
No description provided.