Handle pending changes to tifffile defaults and avoid test warnings#6460
Merged
mkcor merged 8 commits intoscikit-image:mainfrom Oct 19, 2022
Merged
Handle pending changes to tifffile defaults and avoid test warnings#6460mkcor merged 8 commits intoscikit-image:mainfrom
tifffile defaults and avoid test warnings#6460mkcor merged 8 commits intoscikit-image:mainfrom
Conversation
use current behavior for backwards compatibility
mkcor
reviewed
Aug 16, 2022
Member
mkcor
left a comment
There was a problem hiding this comment.
Thanks for taking care of this! 🙏
I do see the warnings from the IO module on my system:
Python 3.9.4 | packaged by conda-forge | (default, May 10 2021, 22:13:33)
scikit-image.git@29770dbc9fd34131d69b6f9c2fbb1ead835562cd#egg=scikit_image
tifffile==2022.5.4Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
This was referenced Oct 17, 2022
stefanv
reviewed
Oct 17, 2022
Member
stefanv
left a comment
There was a problem hiding this comment.
Looks good to me; just the one typo in the docstring, all the other suggestions are stylistic.
Co-authored-by: Stefan van der Walt <sjvdwalt@gmail.com>
stefanv
approved these changes
Oct 17, 2022
mkcor
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #5337
closes #6558
closes #6572
I see no warnings from the IO module on my system, but it is possible some other versions of dependencies may still warn. Let's see how the tests here go.
We need to decide if we should be adding these kwargs in the plugins for backwards compatibility or if our policy is just to dispatch to whatever the tifffile defaults are when writing unless the user supplies kwargs. In this PR, I chose to automatically set the needed
kwargsinternally to the plugin for backwards compatiiblity and for consistent behavior across current and future tifffile versions.For reviewers
later.
__init__.py.doc/release/release_dev.rst.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.xrun-benchmarklabel. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.