Backport: use fused types in denoise, warp (#3486)#3880
Merged
jni merged 2 commits intoscikit-image:v0.14.xfrom May 12, 2019
Merged
Backport: use fused types in denoise, warp (#3486)#3880jni merged 2 commits intoscikit-image:v0.14.xfrom
jni merged 2 commits intoscikit-image:v0.14.xfrom
Conversation
* MNT: Add a fused numeric type to make fused_types more constent. * MNT: make the interpolation use fused types for any->any type interpolation of images. * MNT: Move even more numpy function calls from Cython to Python. * MNT: More explicit type specifying * BUG: Use fused floats in denoise Pull all denoise array allocation out into python Function used in python should be def not cdef Have the correct number of arguments * MNT: Add additional type check for denoise, more docs * PEP8 fixes * Remove redundant array u and view cu * Mutate output array in Cython and trim in Python * Replace height and width with existing rows and cols * Change iteration order to match array order * Move range_lut and color_lut properly from Cy to Py * Ravel range LUT which is expected to be 1D * Update comment in denoise bilateral tests * Fix relative import in interpolation.pyx * BENCH: Benchmark for warping with many types * Rename warp benchmark file * Update pointer syntax Co-Authored-By: Mark Harfouche <mark.harfouche@gmail.com>
|
Hello @hmaarrfk! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-05-01 03:21:34 UTC |
Member
Author
|
Attempt to get #3787 passed. |
Member
|
@hmaarrfk this looks like it's going to be a nightmare to backport. My idea is to instead use |
Member
Author
|
the backport is actually working. I just pushed through an other necessary backport to make this one workout. Lets get this through and move on. |
Member
Author
|
@jni this is the last PR in the 0.14.3 series. All seems to be passing now. If you still wanted this to be backported, then I think we should get this going !!! |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MNT: Add a fused numeric type to make fused_types more constent.
MNT: make the interpolation use fused types for any->any type interpolation of images.
MNT: Move even more numpy function calls from Cython to Python.
MNT: More explicit type specifying
BUG: Use fused floats in denoise
Pull all denoise array allocation out into python
Function used in python should be def not cdef
Have the correct number of arguments
MNT: Add additional type check for denoise, more docs
PEP8 fixes
Remove redundant array u and view cu
Mutate output array in Cython and trim in Python
Replace height and width with existing rows and cols
Change iteration order to match array order
Move range_lut and color_lut properly from Cy to Py
Ravel range LUT which is expected to be 1D
Update comment in denoise bilateral tests
Fix relative import in interpolation.pyx
BENCH: Benchmark for warping with many types
Rename warp benchmark file
Update pointer syntax
Co-Authored-By: Mark Harfouche mark.harfouche@gmail.com
Description
Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.@meeseeksdev backport to v0.14.x