Skip to content

Backport: use fused types in denoise, warp (#3486)#3787

Closed
jni wants to merge 1 commit intoscikit-image:v0.14.xfrom
jni:backport-fused
Closed

Backport: use fused types in denoise, warp (#3486)#3787
jni wants to merge 1 commit intoscikit-image:v0.14.xfrom
jni:backport-fused

Conversation

@jni
Copy link
Copy Markdown
Member

@jni jni commented Mar 6, 2019

  • MNT: Add a fused numeric type to make fused_types more constent.

  • MNT: make the interpolation use fused types for any->any type interpolation of images.

  • MNT: Move even more numpy function calls from Cython to Python.

  • MNT: More explicit type specifying

  • BUG: Use fused floats in denoise

Pull all denoise array allocation out into python
Function used in python should be def not cdef
Have the correct number of arguments

  • MNT: Add additional type check for denoise, more docs

  • PEP8 fixes

  • Remove redundant array u and view cu

  • Mutate output array in Cython and trim in Python

  • Replace height and width with existing rows and cols

  • Change iteration order to match array order

  • Move range_lut and color_lut properly from Cy to Py

  • Ravel range LUT which is expected to be 1D

  • Update comment in denoise bilateral tests

  • Fix relative import in interpolation.pyx

  • BENCH: Benchmark for warping with many types

  • Rename warp benchmark file

  • Update pointer syntax

Co-Authored-By: Mark Harfouche mark.harfouche@gmail.com

Description

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

* MNT: Add a fused numeric type to make fused_types more constent.

* MNT: make the interpolation use fused types for any->any type interpolation of images.

* MNT: Move even more numpy function calls from Cython to Python.

* MNT: More explicit type specifying

* BUG: Use fused floats in denoise

Pull all denoise array allocation out into python
Function used in python should be def not cdef
Have the correct number of arguments

* MNT: Add additional type check for denoise, more docs

* PEP8 fixes

* Remove redundant array u and view cu

* Mutate output array in Cython and trim in Python

* Replace height and width with existing rows and cols

* Change iteration order to match array order

* Move range_lut and color_lut properly from Cy to Py

* Ravel range LUT which is expected to be 1D

* Update comment in denoise bilateral tests

* Fix relative import in interpolation.pyx

* BENCH: Benchmark for warping with many types

* Rename warp benchmark file

* Update pointer syntax

Co-Authored-By: Mark Harfouche <mark.harfouche@gmail.com>
@pep8speaks
Copy link
Copy Markdown

Hello @jni! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 19:68: E226 missing whitespace around arithmetic operator

@hmaarrfk
Copy link
Copy Markdown
Member

hmaarrfk commented May 6, 2019

Superseded by #3486

@hmaarrfk
Copy link
Copy Markdown
Member

This was done in #3880

@hmaarrfk hmaarrfk closed this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants