Backport PR #3052 on branch v0.14.x (Allow float->float conversion of any range)#3390
Merged
soupault merged 2 commits intoscikit-image:v0.14.xfrom Sep 7, 2018
Conversation
Member
|
this should include theses fixes #3391 |
assert_allclose exists, but I think in this case we should make a stronger assertion
Member
|
@hmaarrfk yep! Thanks! Done! =) |
Codecov Report
@@ Coverage Diff @@
## v0.14.x #3390 +/- ##
===========================================
+ Coverage 86.59% 86.62% +0.03%
===========================================
Files 337 337
Lines 27400 27403 +3
===========================================
+ Hits 23726 23739 +13
+ Misses 3674 3664 -10
Continue to review full report at Codecov.
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #3052: Allow float->float conversion of any range