Skip to content

Backport PR #3052 on branch v0.14.x (Allow float->float conversion of any range)#3390

Merged
soupault merged 2 commits intoscikit-image:v0.14.xfrom
meeseeksmachine:auto-backport-of-pr-3052-on-v0.14.x
Sep 7, 2018
Merged

Backport PR #3052 on branch v0.14.x (Allow float->float conversion of any range)#3390
soupault merged 2 commits intoscikit-image:v0.14.xfrom
meeseeksmachine:auto-backport-of-pr-3052-on-v0.14.x

Conversation

@meeseeksmachine
Copy link
Copy Markdown

Backport PR #3052: Allow float->float conversion of any range

@lumberbot-app lumberbot-app bot added this to the 0.15 milestone Sep 6, 2018
@hmaarrfk
Copy link
Copy Markdown
Member

hmaarrfk commented Sep 7, 2018

this should include theses fixes #3391

assert_allclose exists, but I think in this case we should make a 
stronger assertion
@jni
Copy link
Copy Markdown
Member

jni commented Sep 7, 2018

@hmaarrfk yep! Thanks! Done! =)

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 7, 2018

Codecov Report

Merging #3390 into v0.14.x will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v0.14.x    #3390      +/-   ##
===========================================
+ Coverage    86.59%   86.62%   +0.03%     
===========================================
  Files          337      337              
  Lines        27400    27403       +3     
===========================================
+ Hits         23726    23739      +13     
+ Misses        3674     3664      -10
Impacted Files Coverage Δ
skimage/util/dtype.py 89.75% <100%> (ø) ⬆️
skimage/util/tests/test_dtype.py 100% <100%> (ø) ⬆️
skimage/draw/_random_shapes.py 96.84% <0%> (+1.05%) ⬆️
skimage/io/_plugins/util.py 60.71% <0%> (+1.78%) ⬆️
skimage/io/tests/test_simpleitk.py 73.68% <0%> (+3.5%) ⬆️
skimage/io/_plugins/gtk_plugin.py 30.55% <0%> (+5.55%) ⬆️
skimage/io/_plugins/simpleitk_plugin.py 81.81% <0%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9beda7...c214e02. Read the comment docs.

@soupault soupault merged commit 797f9ee into scikit-image:v0.14.x Sep 7, 2018
@soupault soupault modified the milestones: 0.15, 0.14.1 Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants