assert_all_close doesn't exist, make it assert_array_equal#3391
Merged
emmanuelle merged 1 commit intoscikit-image:masterfrom Sep 7, 2018
Merged
assert_all_close doesn't exist, make it assert_array_equal#3391emmanuelle merged 1 commit intoscikit-image:masterfrom
assert_array_equal#3391emmanuelle merged 1 commit intoscikit-image:masterfrom
Conversation
assert_allclose exists, but I think in this case we should make a stronger assertion
Codecov Report
@@ Coverage Diff @@
## master #3391 +/- ##
=========================================
Coverage ? 86.81%
=========================================
Files ? 341
Lines ? 27406
Branches ? 0
=========================================
Hits ? 23792
Misses ? 3614
Partials ? 0
Continue to review full report at Codecov.
|
Member
|
LGTM, merging (and I think it will fix Travis which is broken because of this test). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assert_allclose exists, but I think in this case we should make a
stronger assertion
@jni
Re: PR #3052
For reviewers
(Don't remove the checklist below.)
later.
__init__.py.doc/release/release_dev.rst.@meeseeksdev backport to v0.14.x