Protect exposure.histogram from integer overflow#1232
Merged
blink1073 merged 1 commit intoscikit-image:masterfrom Nov 25, 2014
Merged
Protect exposure.histogram from integer overflow#1232blink1073 merged 1 commit intoscikit-image:masterfrom
blink1073 merged 1 commit intoscikit-image:masterfrom
Conversation
Fixes scikit-image#1228 . I also removed a min() calculation and prevented an image copy when offset is 0, which is most of the time.
Contributor
|
Should we test/update adapthist as well? |
Member
|
thanks @jni ! Looks good to me @blink1073 equalize_adapthist calls skimage.img_as_uint so we should be fine I guess |
Member
|
This looks good to me; @blink1073 if you are happy, please go ahead and merge. |
Member
Author
|
@blink1073 what @emmanuelle said. =P The problem for adapthist is different from this one, because it uses img_as_uint. Yes, we are having a discussion in #1229 about whether our image conversion routines do the right thing, but that's not what this PR addresses. |
Contributor
|
Okay, okay... |
blink1073
added a commit
that referenced
this pull request
Nov 25, 2014
Protect exposure.histogram from integer overflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1228 .
I also removed a min() calculation and prevented an image copy when
offset is 0, which is most of the time.