test: expand growth serialization coverage to all axis types#1076
Merged
henryiii merged 3 commits intohenryiii/feat/axesgrowthfrom Jan 28, 2026
Merged
test: expand growth serialization coverage to all axis types#1076henryiii merged 3 commits intohenryiii/feat/axesgrowthfrom
henryiii merged 3 commits intohenryiii/feat/axesgrowthfrom
Conversation
Co-authored-by: henryiii <4616906+henryiii@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update axes growth support in serialization based on review feedback
test: expand growth serialization coverage to all axis types
Jan 28, 2026
Member
|
pre-commit.ci autofix |
Member
|
This is excellent, by the way, exactly how I would have written it. It's parametrized, and each parameter has an ID so that it prints nicely on the summary. |
henryiii
added a commit
that referenced
this pull request
Jan 28, 2026
* feat: support axes growth in serialization Signed-off-by: Henry Schreiner <henryfs@princeton.edu> * test: expand growth serialization coverage to all axis types (#1076) * Initial plan * test: expand growth serialization test to cover all axis types Co-authored-by: henryiii <4616906+henryiii@users.noreply.github.com> * style: pre-commit fixes --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: henryiii <4616906+henryiii@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Signed-off-by: Henry Schreiner <henryfs@princeton.edu> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: henryiii <4616906+henryiii@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback requesting comprehensive test coverage for growth trait serialization across all supported axis types.
Changes
test_round_trip_growthfrom single Integer axis test to parametrized test covering all 5 axis types supporting growth: Integer, Regular, Variable, IntCategory, and StrCategoryThe parametrized approach ensures all serialization code paths added in #1074 for the growth trait are properly tested.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.