Skip to content

fix: prevent teardown from crashing GPU test suite#3747

Merged
ianna merged 1 commit intoscikit-hep:mainfrom
ianna:ianna/fix_cleanup_cuda
Nov 27, 2025
Merged

fix: prevent teardown from crashing GPU test suite#3747
ianna merged 1 commit intoscikit-hep:mainfrom
ianna:ianna/fix_cleanup_cuda

Conversation

@ianna
Copy link
Copy Markdown
Member

@ianna ianna commented Nov 25, 2025

First synchronize, then free memory. This avoids freeing memory still in use by the GPU.

@ianna ianna requested a review from maxymnaumchyk November 25, 2025 16:57
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.71%. Comparing base (b749e49) to head (8d27be1).
⚠️ Report is 475 commits behind head on main.

Additional details and impacted files

see 200 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3747

Copy link
Copy Markdown
Collaborator

@maxymnaumchyk maxymnaumchyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image

All the tests are running successfully at my local machine. Thanks!

@ianna ianna merged commit 49cfcba into scikit-hep:main Nov 27, 2025
44 checks passed
ikrommyd pushed a commit to ikrommyd/awkward that referenced this pull request Dec 9, 2025
fix to prevent teardown from crashing our test suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants