fix: ArrayBuilder.__bool__ raises TypeError when builder length is 1#3738
Merged
ianna merged 3 commits intoscikit-hep:mainfrom Nov 26, 2025
Merged
fix: ArrayBuilder.__bool__ raises TypeError when builder length is 1#3738ianna merged 3 commits intoscikit-hep:mainfrom
ArrayBuilder.__bool__ raises TypeError when builder length is 1#3738ianna merged 3 commits intoscikit-hep:mainfrom
Conversation
ArrayBuilder is not subscriptable, fetch the value from the snapshot instead.ArrayBuilder.__bool__ raises TypeError when builder length is 1
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
Member
|
@all-contributors please add @T90REAL for code |
Contributor
|
I've put up a pull request to add @T90REAL! 🎉 |
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3738 |
ikrommyd
pushed a commit
to ikrommyd/awkward
that referenced
this pull request
Dec 9, 2025
…is 1 (scikit-hep#3738) is not subscriptable, fetch the value from the snapshot instead. Co-authored-by: Ianna Osborne <ianna.osborne@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3732
The implementation explicitly checks
len(self) == 1, but then attempts to accessself[0], even thoughArrayBuilderdoes not implement__getitem__. Change it to fetch the value from the snapshot instead.