fix: SVG bug in diagram depicting ragged aggregation#3648
Merged
Conversation
Member
Author
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3648 |
ianna
approved these changes
Sep 15, 2025
Member
ianna
left a comment
There was a problem hiding this comment.
@jpivarski - thinks for fixing it! Please, merge if you are done with it. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was planning to un-assign all of the issues that are assigned to me across many repos so that I can use this GitHub search as a to-do list. I came across #3009 and not only is it out of date (a complaint about formatting of documentation that no longer exists), but the problem with that SVG file was fixed as it was presented in various tutorials. But it wasn't fixed in this repo, which can be considered its source, so I'm copying in the fixed SVG now.
The bad SVG doesn't render as bad on all systems, so here's what it looks like on a Mac in Chrome (where it does render badly):