fix: ensure the args for ufunc are ArrayLikes#3614
Merged
ianna merged 1 commit intoscikit-hep:pre-commit-ci-update-configfrom Aug 26, 2025
Merged
Conversation
Member
Thanks for fixing it! It would be good to understand the cause of it. |
Collaborator
Author
|
It's weird to me, because the typing resolution for the non-typetracer case looks the same, and it doesn't complain there. I'll try to understand it better, but I'd suggest we move on with this as this doesn't affect any runtime behavior. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
ianna
approved these changes
Aug 26, 2025
Member
ianna
left a comment
There was a problem hiding this comment.
@pfackeldey - Great! Thanks for fixing it.
a69de92
into
scikit-hep:pre-commit-ci-update-config
47 checks passed
ianna
added a commit
that referenced
this pull request
Aug 26, 2025
* chore: update pre-commit hooks updates: - [github.com/astral-sh/ruff-pre-commit: v0.12.2 → v0.12.7](astral-sh/ruff-pre-commit@v0.12.2...v0.12.7) - [github.com/pre-commit/mirrors-mypy: v1.16.1 → v1.17.1](pre-commit/mirrors-mypy@v1.16.1...v1.17.1) * fix: ensure the args for ufunc are ArrayLikes (#3614) typing: ensure the args for ufunc are ArrayLikes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ianna Osborne <ianna.osborne@cern.ch> Co-authored-by: Peter Fackeldey <fackeldey.peter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure why this is not inferred anymore as before, but in order to satisfy the typing interface we pin the type properly.