Merged
Conversation
pfackeldey
approved these changes
Jun 11, 2025
Collaborator
pfackeldey
left a comment
There was a problem hiding this comment.
Thanks this looks good to me!
ianna
added a commit
that referenced
this pull request
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3530
Supersedes #3531
Fixes
np.count_nonzeroreturning a numpy integer instead of a python integer in numpy 2.3 and also ignores the warning/error of setting rtol or atol to nan or np.inf innp.testing.assert_allclosethat is also new in numpy 2.3.The numexpr pin is temporary to make the ci pass. The numexpr 2.11 compatibility will be fixed in a separate PR.