ENH: Add automatic rebuild#72
Merged
larsoner merged 6 commits intoscientific-python:masterfrom May 20, 2025
Merged
Conversation
larsoner
added a commit
to matthieutrs/circleci-artifacts-redirector-action
that referenced
this pull request
May 20, 2025
* upstream/master: Update NCC; pin fetch to v2 (scientific-python#71) ENH: Add automatic rebuild (scientific-python#72) Build(deps): Bump undici from 5.28.5 to 5.29.0 Making config example and narrative consistent (scientific-python#67)
bsipocz
reviewed
May 20, 2025
| - run: ncc build index.js | ||
| env: | ||
| NODE_OPTIONS: "--openssl-legacy-provider" | ||
| - uses: autofix-ci/action@551dded8c6cc8a1054039c8bc0b8b48c51dfc6ef |
Member
There was a problem hiding this comment.
I would say we should pin the latest 1.3.1 hash as only the readme changed since then.
Collaborator
Author
There was a problem hiding this comment.
Their official docs suggest to use this hash, so maybe better to follow that?
Member
There was a problem hiding this comment.
I don't think dependabot would pick up hash changes (without tag changes), so I would open a PR for their readme. (At least following the readme change history I didn't get the notion of them indeed suggesting to tag to individual hashes unassociated with any release)
Collaborator
Author
There was a problem hiding this comment.
Ahh I didn't look at their readme just https://autofix.ci/ and https://autofix.ci/setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see if it works, it should rebuild and modify
dist/index.js!