Merged
Conversation
Owner
schuyler
pushed a commit
that referenced
this pull request
Dec 31, 2025
Fork PRs have limited GITHUB_TOKEN permissions, causing the coverage comment step and artifact upload to fail with "Resource not accessible by integration" errors. Add continue-on-error to these steps so they don't break the CI run. Also fix artifact name collision by adding matrix.os suffix to test results artifact name. Related to #240
Owner
|
Tests are failing due to a CI configuration issue, not the code itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original author changed the default behavior of drag & drop to allow inlining JPEG images as data:image blocks when they are dragged into the text editor.
Unfortunately, the implementation as it was overwrote the default drag behavior completely, bit this is easily fixed with a message to super.
While testing this, I noticed that the code has some other quirks. It inlines all file types, not just JPEGs, and the inlining isn't undo-able; I made some comments so that someone may pick this up at some point.