Conversation
…ns for preferences This commit completes localization support for Russian (ru-RU) and Arabic (ar) preference view controllers, addressing two incomplete internationalization issues. Changes: - Russian (ru-RU) localization: * Completed MPMarkdownPreferencesViewController.strings (added 13 missing entries) * Created MPTerminalPreferencesViewController.strings (18 lines, 6 entries) * Created MPGeneralPreferencesViewController.strings (27 lines, 9 entries) * Created MPHtmlPreferencesViewController.strings (63 lines, 21 entries) * Created MPEditorPreferencesViewController.strings (63 lines, 21 entries) * Total: 213 lines across 5 files - Arabic (ar) localization: * Created MPMarkdownPreferencesViewController.strings (42 lines, 14 entries) * Created MPTerminalPreferencesViewController.strings (18 lines, 6 entries) * Created MPGeneralPreferencesViewController.strings (27 lines, 9 entries) * Created MPHtmlPreferencesViewController.strings (63 lines, 21 entries) * Created MPEditorPreferencesViewController.strings (63 lines, 21 entries) * Total: 213 lines across 5 files - Xcode project updates: * Added PBXFileReference entries for 4 new Russian .strings files * Added Russian references to 4 preference view controller variant groups * Arabic files were already referenced in project (files now created) All translations use formal/polite forms appropriate for UI text. Technical terms (Markdown, Smartypants, Mermaid, Graphviz, Jekyll, TeX) preserved in English as proper nouns across both localizations. Related to #174 Related to #175
Extends international support by adding three additional complete localizations for preference view controllers. Changes: - Hindi (hi) localization: * Created MPMarkdownPreferencesViewController.strings (42 lines, 14 entries) * Created MPTerminalPreferencesViewController.strings (18 lines, 6 entries) * Created MPGeneralPreferencesViewController.strings (27 lines, 9 entries) * Created MPHtmlPreferencesViewController.strings (63 lines, 21 entries) * Created MPEditorPreferencesViewController.strings (63 lines, 21 entries) * Total: 213 lines across 5 files - Ukrainian (uk) localization: * Created MPMarkdownPreferencesViewController.strings (42 lines, 14 entries) * Created MPTerminalPreferencesViewController.strings (18 lines, 6 entries) * Created MPGeneralPreferencesViewController.strings (27 lines, 9 entries) * Created MPHtmlPreferencesViewController.strings (63 lines, 21 entries) * Created MPEditorPreferencesViewController.strings (63 lines, 21 entries) * Total: 213 lines across 5 files - Hebrew (he) localization: * Created MPMarkdownPreferencesViewController.strings (42 lines, 14 entries) * Created MPTerminalPreferencesViewController.strings (18 lines, 6 entries) * Created MPGeneralPreferencesViewController.strings (27 lines, 9 entries) * Created MPHtmlPreferencesViewController.strings (63 lines, 21 entries) * Created MPEditorPreferencesViewController.strings (63 lines, 21 entries) * Total: 213 lines across 5 files - Xcode project updates: * Added 15 new PBXFileReference entries (5 per language) * Added references to all 5 preference view controller variant groups * Total: 639 new lines of translations All translations follow the same conventions as Russian/Arabic localizations, using formal forms appropriate for UI text and preserving technical terms in English (Markdown, Smartypants, Mermaid, Graphviz, Jekyll, TeX). Related to #174 Related to #175
Contributor
Code Coverage ReportCurrent Coverage: 42.21% Coverage Details (Summary) |
Removed "Localization/" prefix from Terminal preference file paths for ru-RU, hi, uk, and he. The MPTerminalPreferencesViewController variant group already has "Localization" as its base path, so file references should be relative (e.g., "hi.lproj/..." not "Localization/hi.lproj/..."). This fixes build errors where Xcode was looking for files at paths like "Localization/Localization/hi.lproj/...". Related to #174 #175
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes preference view controller localizations for five languages, adding comprehensive international support:
Total: 1,065 new lines of translations across 25 localization files
Related Issues
Related to #174 (Russian localization)
Related to #175 (Arabic localization)
Changes
Russian Localization (#174)
Arabic Localization (#175)
Hindi, Ukrainian, Hebrew Localizations
Xcode Project Updates
Translation Approach
All translations:
Code Review
Chico review status: ✅ APPROVED (Russian/Arabic implementation)
No critical issues found. Same approach applied to Hindi, Ukrainian, Hebrew.
Manual Testing Plan
N/A - Localization data files only. CI will validate build succeeds with new translations.