fix computeAABB orientation mult#433
Open
tinglei8 wants to merge 2 commits into
Open
Conversation
Author
|
added one fix for ray.checkCollisionResponse not affected by options |
|
Thanks for these fixes. |
stockhuman
added a commit
to pmndrs/cannon-es
that referenced
this pull request
Mar 7, 2020
yaustar
pushed a commit
to yaustar/cannon.js
that referenced
this pull request
May 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Body.js computeAABB(): the order of quaternion multiplication is fixed.
Steps to reproduce computeAABB error with unmodified lib:
create a body containing a cylinder shape.
when creating the cylinder shape set its localRotation to 45 degrees around z axis.
AABB of the body is not enlarged by tilt of the shape.