ConvexPolyhedron calculateWorldAABB() can return undefined values in max#360
Open
jfaust wants to merge 1 commit into
Open
ConvexPolyhedron calculateWorldAABB() can return undefined values in max#360jfaust wants to merge 1 commit into
jfaust wants to merge 1 commit into
Conversation
robrohan
added a commit
to TheRohans/dapao
that referenced
this pull request
Oct 14, 2018
stockhuman
added a commit
to pmndrs/cannon-es
that referenced
this pull request
Mar 7, 2020
yaustar
pushed a commit
to yaustar/cannon.js
that referenced
this pull request
May 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a situation where the AABB of a Body I was creating had a
NaNvalue in its calculated AABB. Turns out, if a ConvexPolyhedron has vertices where one or more components are always decreasing, theAABB calculation had a bug where the
max[x|y|z]values would remain undefined. This PR fixes the bug and adds a unit test for it.