feat: support loading config from user home directory#89
Merged
Conversation
Owner
|
i think overall i would like this, e.g. to allow people to set some values globally more easily. but as implemented in this PR it'll load only the user's global config (i.e. in ~/.config/linear/linear.toml) and not the repo specific one. i think we'd need to merge the configs or something. do you agree? |
…file values The README documented that environment variables take precedence over config file values, but the code had the opposite behavior. This fix corrects the precedence order in getRawOption to match the documentation: 1. CLI flags (highest priority) 2. Environment variables 3. Config file (lowest priority) Also adds subprocess-based tests that verify: - Env vars win when both env var and config file are present - Config file is used as fallback when no env var is set 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add support for loading `.linear.toml` from user's home directory as a fallback when no project-level config exists: - Unix: `~/.config/linear/linear.toml` or `$XDG_CONFIG_HOME/linear/linear.toml` - Windows: `%APPDATA%\linear\linear.toml` Config precedence (highest to lowest): 1. CLI flags 2. Environment variables 3. Project config (`.linear.toml` in cwd or repo root) 4. User home config 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
5f28b63 to
e396e88
Compare
e396e88 to
03ebf55
Compare
Owner
|
@kfrance FYI i went forward with the merging stuff i mentioned. excited to have global config. thanks for this! |
Contributor
Author
Thanks. Sorry I was just coming back to look over this and see how to improve it. Glad you liked it enough to merge it in. I didn't really think about it, but you are probably right merging them would probably be better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.linear.tomlfrom user's home directory as a fallback config location$XDG_CONFIG_HOME/linear/linear.tomlor~/.config/linear/linear.toml)%APPDATA%\linear\linear.tomlon WindowsConfig Precedence (highest to lowest)
.linear.tomlin cwd or repo root)Test plan
Dependencies: This PR depends on #88 being merged first.
🤖 Generated with Claude Code