fix: environment variables now correctly take precedence over config file values#88
Merged
Merged
Conversation
…file values The README documented that environment variables take precedence over config file values, but the code had the opposite behavior. This fix corrects the precedence order in getRawOption to match the documentation: 1. CLI flags (highest priority) 2. Environment variables 3. Config file (lowest priority) Also adds subprocess-based tests that verify: - Env vars win when both env var and config file are present - Config file is used as fallback when no env var is set 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
6 tasks
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getRawOptionso environment variables take priority over config file values, matching the README documentationDetails
The README states that "environment variables take precedence over config file values", but the code had the opposite behavior. This fix corrects the precedence order:
Test plan
🤖 Generated with Claude Code