Prepare release and bug fix Windows compiled#798
Merged
HJZollner merged 1 commit intoschorschinho:developfrom Nov 26, 2024
Merged
Prepare release and bug fix Windows compiled#798HJZollner merged 1 commit intoschorschinho:developfrom
HJZollner merged 1 commit intoschorschinho:developfrom
Conversation
Collaborator
HJZollner
commented
Nov 26, 2024
- preparing a release for Zenodo DOI
- fixing compiled Windows version
- preparing a release for Zenodo DOI - fixing compiled Windows version
alexcraven
added a commit
to alexcraven/osprey
that referenced
this pull request
Nov 19, 2025
Suggested fix for schorschinho#828, schorschinho#829 (and "better" fix for schorschinho#798). This patch gives more consistent (and concise!) handling of compiled vs non-compiled modes, more consistent use of specified basissetFolder, and predictable behaviour regardless of whether basissetFile is specified as a single string or a cell array of strings. Note, basissetFile as a cell might remain problematic for certain fit_*m functions, which are not addressed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.