Skip to content

Port CopyOnWriteArrayList from Scala.js#2725

Merged
WojciechMazur merged 4 commits intoscala-native:0.4.xfrom
armanbilge:feature/copy-on-write-array-list
Aug 4, 2022
Merged

Port CopyOnWriteArrayList from Scala.js#2725
WojciechMazur merged 4 commits intoscala-native:0.4.xfrom
armanbilge:feature/copy-on-write-array-list

Conversation

@armanbilge
Copy link
Member

Targeted to 0.4.x.

@armanbilge
Copy link
Member Author

I'm confused by the failure.

Error:  nir: Failed binary compatibility check against org.scala-native:nir_2.12:0.4.5! Found 1 potential problems
Error:   * object scala.scalanative.nir.Attr#Volatile does not have a correspondent in current version
Error:     filter with: ProblemFilters.exclude[MissingClassProblem]("scala.scalanative.nir.Attr$Volatile$")
Error:  java.lang.RuntimeException: Failed binary compatibility check against org.scala-native:nir_2.12:0.4.5! Found 1 potential problems

@LeeTibbert
Copy link
Contributor

Thank you for the Scala.js commit & date tags. They really help the next generation who has
to maintain ports.

@ekrich
Copy link
Member

ekrich commented Jul 15, 2022

I'm confused by the failure.

Error:  nir: Failed binary compatibility check against org.scala-native:nir_2.12:0.4.5! Found 1 potential problems
Error:   * object scala.scalanative.nir.Attr#Volatile does not have a correspondent in current version
Error:     filter with: ProblemFilters.exclude[MissingClassProblem]("scala.scalanative.nir.Attr$Volatile$")
Error:  java.lang.RuntimeException: Failed binary compatibility check against org.scala-native:nir_2.12:0.4.5! Found 1 potential problems

I don't see anything you have changed to cause the incompatibility. Are you sure your environment is clean? Takes a while but I would try +clean.

@armanbilge
Copy link
Member Author

@ekrich thanks for the tip, but I don't see how cleaning my local workspace will solve a CI failure :)

Indeed, it looks like a more serious problem. Seems like v0.4.5 was published with a mixture of 0.5.x development stuff in it.

@WojciechMazur WojciechMazur merged commit b4316a7 into scala-native:0.4.x Aug 4, 2022
WojciechMazur pushed a commit to WojciechMazur/scala-native that referenced this pull request Aug 29, 2022
* Initial copy-paste from Scala.js
* Swap ju.ArrayList for js.Array
WojciechMazur pushed a commit to WojciechMazur/scala-native that referenced this pull request Sep 5, 2022
* Initial copy-paste from Scala.js
* Swap ju.ArrayList for js.Array
WojciechMazur pushed a commit to WojciechMazur/scala-native that referenced this pull request Sep 6, 2022
* Initial copy-paste from Scala.js
* Swap ju.ArrayList for js.Array
WojciechMazur pushed a commit that referenced this pull request Sep 6, 2022
* Initial copy-paste from Scala.js
* Swap ju.ArrayList for js.Array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants