Skip to content

Publish sbt during PR validation#73

Merged
dragos merged 1 commit intoscala-ide:masterfrom
adriaanm:master
May 1, 2015
Merged

Publish sbt during PR validation#73
dragos merged 1 commit intoscala-ide:masterfrom
adriaanm:master

Conversation

@adriaanm
Copy link
Contributor

@adriaanm adriaanm commented Apr 30, 2015

Validated by https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-ide/841/consoleFull:

[sbt-republish] --== End Building sbt-republish ==--
[info] --== Deploying Artifacts  ==--
[info] Processing: https://scala-ci.typesafe.com/artifactory/scala-pr-validation-snapshots/
[info] Deploying: sbt-republish
[info] Retrieved from project sbt-republish (commit: bc6157829bcb69943dbd479c94f6abdb56033fe6): 15 artifacts
[info] Deploying: com/typesafe/sbt/compiler-interface-precompiled/0.13.6-on-2.11.7-b697280-SNAPSHOT-for-IDE-SNAPSHOT/compiler-interface-precompiled-0.13.6-on-2.11.7-b697280-SNAPSHOT-for-IDE-SNAPSHOT.jar

Published to https://scala-ci.typesafe.com/artifactory/scala-pr-validation-snapshots/com/typesafe/sbt/compiler-interface-precompiled//0.13.6-on-2.11.7-b697280-SNAPSHOT-for-IDE-SNAPSHOT/

See also adriaanm/scala@b697280

@adriaanm
Copy link
Contributor Author

adriaanm commented Apr 30, 2015

Review by @mpociecha.
/cc @dragos, @skyluc, @cunei, @jsuereth

@ghprb-bot
Copy link

ghprb-bot commented Apr 30, 2015

Refer to this link for build results (access rights to CI server needed):

https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-uber-build-validator/115/
https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-uber-build/118/
Test PASSed.

@mpociecha
Copy link

mpociecha commented Apr 30, 2015

Looks okay - both changes and the result.

On the other hand, I really don't know your build / CI scripts and infrastructure. Hence, I don't think I'm the best person to review changes in uber-build. :)

@adriaanm
Copy link
Contributor Author

adriaanm commented Apr 30, 2015

This script is owned by the IDE team, although we're a consumer for Scala PR validation. I'm happy to merge it from my end, since I've validated it works (link above).

@adriaanm
Copy link
Contributor Author

adriaanm commented Apr 30, 2015

(I don't have permission to merge it, though.)

@adriaanm adriaanm mentioned this pull request Apr 30, 2015
Closed
@adriaanm
Copy link
Contributor Author

adriaanm commented Apr 30, 2015

@mpociecha, who should I contact to get this merged:question:

@mpociecha
Copy link

mpociecha commented May 1, 2015

I'm not a member of Scala IDE team. Probably you should ask @dragos

dragos added a commit that referenced this pull request May 1, 2015
@dragos
Merge pull request #73 from adriaanm/master
dc35488 
Publish sbt during PR validation
@dragos dragos merged commit dc35488 into scala-ide:master May 1, 2015
@adriaanm
Copy link
Contributor Author

adriaanm commented May 1, 2015

Ah, very sorry, I got confused because I saw your name keep popping up around here. Won't happen again.

adriaanm added a commit to adriaanm/scala that referenced this pull request May 1, 2015
@adriaanm
PR validation publishes zinc to $prRepoUrl
3fe3048 
Companion to scala-ide/uber-build#73
@adriaanm adriaanm mentioned this pull request May 1, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adriaanm @ghprb-bot @mpociecha @dragos