Skip to content

Drop spurious applies in unpickler and inliner#25201

Merged
WojciechMazur merged 4 commits intoscala:mainfrom
dotty-staging:fix-25133
Feb 10, 2026
Merged

Drop spurious applies in unpickler and inliner#25201
WojciechMazur merged 4 commits intoscala:mainfrom
dotty-staging:fix-25133

Conversation

@odersky
Copy link
Copy Markdown
Contributor

@odersky odersky commented Feb 6, 2026 •
edited
Loading

Fixes #25133 (hopefully) by dropping spurious Apply nodes of parameterless methods that override some Java method.

Supersedes #25195

@odersky odersky requested review from hamzaremmal and sjrd February 6, 2026 10:22
@odersky odersky changed the title Drop spurious applies in unpickler and inliner#25195 Drop spurious applies in unpickler and inliner Feb 6, 2026
@odersky odersky mentioned this pull request Feb 6, 2026
Closed
@odersky
Copy link
Copy Markdown
Contributor Author

odersky commented Feb 6, 2026

I am stuck with the test failures. I don't think they have anything to do with this change set. Instead we get a temp file from azul that messes up lots of completions in presentation-compiler and I don't know what the pipelining cancellation problem in scripted tests is. @tgodzik @Gedochao can you help get this PR unstuck?

@odersky
Copy link
Copy Markdown
Contributor Author

odersky commented Feb 6, 2026

I should note that these failures did not exist when an identical PR was submitted two days ago #25195. All I did was rename the branch and resubmit.

@tgodzik
Copy link
Copy Markdown
Contributor

tgodzik commented Feb 6, 2026

I should note that these failures did not exist when an identical PR was submitted two days ago #25195. All I did was rename the branch and resubmit.

I will rerun for now to check if they are flaky, otherwise will investigate

@tgodzik
Copy link
Copy Markdown
Contributor

tgodzik commented Feb 6, 2026

Looks like the tests were flaky. The presentation compiler ones might be related to a sonatype issues we've been having. They should be fixed in the next Scala CLI release (we just need a bump)

@odersky
Copy link
Copy Markdown
Contributor Author

odersky commented Feb 6, 2026

Thanks for investigating, @tgodzik!

@WojciechMazur
Copy link
Copy Markdown
Contributor

WojciechMazur commented Feb 9, 2026

@sjrd @hamzaremmal any progress on this one?

lrytz
lrytz approved these changes Feb 9, 2026
View reviewed changes
@odersky @lrytz
Update compiler/src/dotty/tools/dotc/inlines/Inliner.scala
08f52dd 
Co-authored-by: Lukas Rytz <lukas.rytz@gmail.com>
WojciechMazur added a commit to dotty-staging/dotty that referenced this pull request Feb 10, 2026
@WojciechMazur
Add scripted test for scala#25133 and fix in scala#25201
59a9d52
@WojciechMazur
Copy link
Copy Markdown
Contributor

WojciechMazur commented Feb 10, 2026

I've add a scripted test confirming it fails in 3.8.1 but compiles now. Let's merge dotty-staging#76 into this PR (its set to merge into staging/fix-25133 branch, not main) and ship it today in 3.8.2-RC2
AFAIK missing test was the only remaining requirement before merge

@odersky
Copy link
Copy Markdown
Contributor Author

odersky commented Feb 10, 2026

@WojciechMazur OK, I leave it to you to handle it. I am not sure whether to merge into main also? If yes, please go ahead.

@WojciechMazur
Copy link
Copy Markdown
Contributor

WojciechMazur commented Feb 10, 2026 •
edited
Loading

Ok, I'll handle that (including merge) after PR with added tests passes the CI

@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Feb 10, 2026
@WojciechMazur WojciechMazur added this to the 3.8.2 milestone Feb 10, 2026
@WojciechMazur WojciechMazur enabled auto-merge (squash) February 10, 2026 11:57
@WojciechMazur WojciechMazur merged commit 7a02032 into scala:main Feb 10, 2026
59 checks passed
@WojciechMazur WojciechMazur deleted the fix-25133 branch February 10, 2026 13:39
WojciechMazur added a commit that referenced this pull request Feb 10, 2026
@odersky @lrytz @WojciechMazur
Drop spurious applies in unpickler and inliner (#25201)
f204f57 
Fixes #25133 (hopefully) by
dropping spurious Apply nodes of parameterless methods that override
some Java method.

Supersedes #25195

---------

Co-authored-by: Lukas Rytz <lukas.rytz@gmail.com>
Co-authored-by: Wojciech Mazur <wmazur@virtuslab.com>
[Cherry-picked 7a02032]
@WojciechMazur WojciechMazur mentioned this pull request Feb 10, 2026
Merged
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Feb 10, 2026
WojciechMazur added a commit that referenced this pull request Feb 10, 2026
@WojciechMazur
Backport "Drop spurious applies in unpickler and inliner" to 3.8.2 (#…
cb25a6b 
…25233)

Backports #25201 to the 3.8.2-RC2.

PR submitted by the release tooling.
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lrytz lrytz lrytz approved these changes

@sjrd sjrd sjrd approved these changes

@hamzaremmal hamzaremmal Awaiting requested review from hamzaremmal

Assignees

@WojciechMazur WojciechMazur

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

3.8.2

Development

Successfully merging this pull request may close these issues.

Scala 3.3.7 compiles parameterless call to Apply in Tasty

6 participants

@odersky @tgodzik @WojciechMazur @lrytz @sjrd @hamzaremmal