Stdlib bootstrapped explicit types#18029
Closed
nicolasstucki wants to merge 2 commits intoscala:mainfrom
Closed
Conversation
Contributor
Author
|
The test failed due to #18033. We need to wait until this PR is merged to re-test. |
6643a9e to
b358290
Compare
sjrd
reviewed
Jun 23, 2023
Contributor
Author
|
I will change this directly is Scala 2 |
nicolasstucki
added a commit
to nicolasstucki/scala
that referenced
this pull request
Jun 26, 2023
Add explicit result type to methods where Scala 2 and Scala 3 disagree with the inferred type. The aim is to have the same type in the Scala 2 pickles and the Scala 3 TASTy. Follow up of scala#10435 These where identified in and tested in * scala/scala3#18032 * scala/scala3#18029 * scala/scala3#17975 (BitSet)
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
May 2, 2025
Add explicit result type to methods where Scala 2 and Scala 3 disagree with the inferred type. The aim is to have the same type in the Scala 2 pickles and the Scala 3 TASTy. Follow up of scala/scala#10435 These where identified in and tested in * scala#18032 * scala#18029 * scala#17975 (BitSet)
hamzaremmal
pushed a commit
that referenced
this pull request
May 7, 2025
Add explicit result type to methods where Scala 2 and Scala 3 disagree with the inferred type. The aim is to have the same type in the Scala 2 pickles and the Scala 3 TASTy. Follow up of scala/scala#10435 These where identified in and tested in * #18032 * #18029 * #17975 (BitSet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit cloned the original source files. The second commit adds explicit result types.