ClassfileParser: allow missing param names (for JDK 21)#17536
Merged
smarter merged 1 commit intoscala:mainfrom May 22, 2023
SethTisue:fix-classfile-parsing-on-jdk-21
Merged
ClassfileParser: allow missing param names (for JDK 21)#17536smarter merged 1 commit intoscala:mainfrom SethTisue:fix-classfile-parsing-on-jdk-21
smarter merged 1 commit intoscala:mainfrom
SethTisue:fix-classfile-parsing-on-jdk-21
Conversation
this is a forward port of scala/scala#10397 (fixing scala/bug#12783, from which Scala 3 also suffers)
Contributor
|
This will be included in the Scala 3.3.0-RC7? |
Member
Author
Nah, it can wait for 3.3.1. |
smarter
approved these changes
May 22, 2023
SethTisue
added a commit
to SethTisue/scala
that referenced
this pull request
May 25, 2023
this should work on JDK 21 now that scala/scala3#17536 has been merged
Member
Author
(It's in 3.3.1-RC1, which is now on Maven Central.) |
SethTisue
added a commit
to SethTisue/scala
that referenced
this pull request
May 25, 2023
this should work on JDK 21 now that scala/scala3#17536 has been merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a forward port of scala/scala#10397 (fixing scala/bug#12783, from which Scala 3 also suffers) — the same fix we'll be shipping in 2.12.18 and 2.13.11
I haven't included a unit test, because
but I did manually test it locally, by bootstrapping on JDK 11, publishing the resulting compiler locally, and then launching the REPL on JDK 21 and evaluating
2 + 2on 3.3.0-RC6, that fails with:
whereas with this change, it succeeds.