Require backticks when defining a type called ?#9735
Merged
dwijnand merged 2 commits intoscala:2.13.xfrom Aug 26, 2021
Merged
Conversation
14669f3 to
cd3f643
Compare
Upgrade the deprecation warning from 2.13.6 into an error (but only at definition site and not use site for now), the ultimate goal would be to allow and encourage `?` as a wildcard in Scala 2 by default so we can repurpose `_` in Scala 3 without causing too much disruption.
dwijnand
reviewed
Aug 26, 2021
dwijnand
approved these changes
Aug 26, 2021
Member
dwijnand
left a comment
There was a problem hiding this comment.
LGTM. Just wondering on the messaging.
cd3f643 to
f2f9ae9
Compare
SethTisue
added a commit
to scala/community-build
that referenced
this pull request
Aug 29, 2021
by unfreezing it; the commit we were frozen at was running afoul of scala/scala#9735
smarter
added a commit
to smarter/scala
that referenced
this pull request
Apr 5, 2022
Like scala#9721, the goal here is to ease cross-compilation between Scala 2 and 3 code as we prepare for `_` as wildcard to be deprecated in Scala 3 (cf scala/scala3#5379). This is technically a source-breaking change, but using a type named ? without backticks is deprecated since 2.13.6 (scala#9626) and defining a type named ? without backticks is disallowed since 2.13.7 (scala#9735). The only known user of ? as a type name was the kind-projector plugin, but support for this syntax was removed from the plugin a year ago (typelevel/kind-projector#186), so I believe this change won't be disruptive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the deprecation warning from 2.13.6 into an error (but only at
definition site and not use site for now), the ultimate goal would be to
allow and encourage
?as a wildcard in Scala 2 by default so we canrepurpose
_in Scala 3 without causing too much disruption.