GitHub Actions: build and test on Windows [ci: last-only] by griggt · Pull Request #9496 · scala/scala

griggt · 2021-02-11T08:55:42Z

An experimental GitHub Actions port of #9493.

I've kept Ubuntu in the matrix for comparison.

.github/workflows/ci.yml

SethTisue · 2021-04-21T01:25:13Z

I think it's sufficient for this PR to just test on JDK 8. That would achieve parity with what we have on Jenkins. Adding testing on 11 and/or 16 can be considered separately; there is WIP for JDK 16 on 2.13.x at #9579. Once that lands we could consider whether to expand it to 2.12.x and/or expand it to 11.

In the past week, I've been brushing up on GitHub Actions, adding it to some low-stakes repos to get a feel for it, so I now feel able to move forward with this PR.

griggt · 2021-04-21T01:36:38Z

In that case I would recommend a workflow structure similar to that in 25aa274, avoiding the unnecessary complexity of the upload-artifact and download-artifact actions used in the fanout approach in 50a9924.

.github/workflows/ci.yml

SethTisue · 2021-04-21T02:14:10Z

For comparison purposes, a recent Jenkins run looks like: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-windows/2098/consoleFull

SethTisue · 2021-04-21T02:19:49Z

(I'll do some squashing before merge, and remove the temporary TODO thing in ci.yml, too.)

@lrytz I think we could merge this and shut down our Jenkins Windows stuff forever.

dwijnand · 2021-04-21T07:27:15Z

Let's pair review this today so we can land it quickly.

lrytz

Looks very good! Intuitively it seems to me we should align the scripts with what we do in .travis.yml.

lrytz · 2021-04-21T14:37:00Z

.github/workflows/ci.yml

+          javac -version
+          generateRepositoriesConfig
+          # Pass these environment vars to subsequent steps
+          echo "SBT=sbt -Dsbt.override.build.repos=true -Dsbt.repository.config=${sbtRepositoryConfig}" >> $GITHUB_ENV


we don't do scripts/common / generateRepositoriesConfig / sbt.override.build.repos in the travis build, why here?

scala/.travis.yml

Lines 43 to 46 in 52cdad9

- set -e

- sbt setupPublishCore generateBuildCharacterPropertiesFile headerCheck publishLocal

- STARR=$(sed -n 's/^maven\.version\.number=//p' buildcharacter.properties) && echo $STARR

- sbt -Dstarr.version=$STARR setupValidateTest compile

Probably no reason except that we copied scripts/jobs/integrate/windows rather than copying .travis.yml, which have probably diverged from each other accidentally. I agree we should try for the simpler version.

Cool! The pr testing in travis doesn't use anything from scripts, which is what should be our long-term goal.

lrytz · 2021-04-21T14:39:21Z

.github/workflows/ci.yml

+        run: |
+          source scripts/common
+          parseScalaProperties buildcharacter.properties
+          $SBT -Dstarr.version=$maven_version_number -warn setupValidateTest testAll


why -warn?

beats me, but .travis.yml has it as well

Ah, on 2.12, but not anymore on 2.13.

ah, good catch. I'll remove it

SethTisue · 2021-04-21T14:45:42Z

I suggest we merge this anyway despite the divergence from .travis.yml, since the immediate goal is to get rid of Windows Jenkins. Then I can address the divergence in a separate PR.

lrytz · 2021-04-21T14:51:57Z

OK if you prefer, though I don't think it's much work to align with travis, and we need to rebase this PR anyway to squash the commits and remove the TODO.

Co-authored-by: Seth Tisue <seth@tisue.net>

SethTisue · 2021-04-21T17:56:12Z

followup PR is #9585

and remove obsolete CI scripts forward-ports scala#9496 and scala#9585 Co-authored-by: Seth Tisue <seth@tisue.net>

scala-jenkins added this to the 2.12.14 milestone Feb 11, 2021

griggt mentioned this pull request Feb 11, 2021

Travis-CI: build and test on Windows #9493

Closed

SethTisue added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Feb 11, 2021

dwijnand reviewed Feb 15, 2021

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

dwijnand mentioned this pull request Feb 15, 2021

Ignore CR (\r) when reading .jvmopts, for Windows dwijnand/sbt-extras#308

Open

griggt changed the title ~~GitHub Actions: build and test on Windows~~ GitHub Actions: build and test on Windows [ci: last-only] Feb 16, 2021

SethTisue mentioned this pull request Feb 19, 2021

Whither scala/scala CI? scala/scala-dev#751

Open

SethTisue self-assigned this Apr 21, 2021

SethTisue force-pushed the wip/gh-actions-windows branch from 13b8f80 to ec36685 Compare April 21, 2021 01:55

griggt commented Apr 21, 2021

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

SethTisue marked this pull request as ready for review April 21, 2021 02:19

SethTisue requested a review from dwijnand April 21, 2021 02:20

lrytz reviewed Apr 21, 2021

View reviewed changes

griggt and others added 3 commits April 21, 2021 10:33

bump sbt to 1.3.13

728aed2

Co-authored-by: Seth Tisue <seth@tisue.net>

GitHub Actions: build and test on Windows

a1dcdcf

Co-authored-by: Seth Tisue <seth@tisue.net>

remove obsolete CI scripts

6aed5b0

SethTisue force-pushed the wip/gh-actions-windows branch from 5658e6e to 6aed5b0 Compare April 21, 2021 17:34

SethTisue mentioned this pull request Apr 21, 2021

GitHub Actions: Windows CI: align with Travis-CI (simpler bootstrap) [ci: last-only] #9585

Merged

SethTisue enabled auto-merge April 21, 2021 17:56

SethTisue merged commit 5430edf into scala:2.12.x Apr 21, 2021

SethTisue added a commit to SethTisue/scala that referenced this pull request Apr 22, 2021

[forward port from 2.12.x] GitHub Actions: build and test on Windows

ab8c238

and remove obsolete CI scripts forward-ports scala#9496 and scala#9585 Co-authored-by: Seth Tisue <seth@tisue.net>

SethTisue mentioned this pull request Apr 22, 2021

[forward port from 2.12.x] GitHub Actions: build and test on Windows #9591

Merged

SethTisue mentioned this pull request Apr 23, 2021

Decommission Jenkins Windows workers scala/scala-jenkins-infra#260

Closed

SethTisue added a commit to SethTisue/scala that referenced this pull request Apr 23, 2021

[forward port from 2.12.x] GitHub Actions: build and test on Windows

52745d0

and remove obsolete CI scripts forward-ports scala#9496 and scala#9585 Co-authored-by: Seth Tisue <seth@tisue.net>

	- set -e
	- sbt setupPublishCore generateBuildCharacterPropertiesFile headerCheck publishLocal
	- STARR=$(sed -n 's/^maven\.version\.number=//p' buildcharacter.properties) && echo $STARR
	- sbt -Dstarr.version=$STARR setupValidateTest compile

Conversation

griggt commented Feb 11, 2021

Uh oh!

Uh oh!

SethTisue commented Apr 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

griggt commented Apr 21, 2021

Uh oh!

Uh oh!

SethTisue commented Apr 21, 2021

Uh oh!

SethTisue commented Apr 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dwijnand commented Apr 21, 2021

Uh oh!

lrytz left a comment

Choose a reason for hiding this comment

Uh oh!

lrytz Apr 21, 2021

Choose a reason for hiding this comment

Uh oh!

SethTisue Apr 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lrytz Apr 21, 2021

Choose a reason for hiding this comment

Uh oh!

lrytz Apr 21, 2021

Choose a reason for hiding this comment

Uh oh!

SethTisue Apr 21, 2021

Choose a reason for hiding this comment

Uh oh!

lrytz Apr 21, 2021

Choose a reason for hiding this comment

Uh oh!

SethTisue Apr 21, 2021

Choose a reason for hiding this comment

Uh oh!

SethTisue commented Apr 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lrytz commented Apr 21, 2021

Uh oh!

SethTisue commented Apr 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

SethTisue commented Apr 21, 2021 •

edited

Loading

SethTisue commented Apr 21, 2021 •

edited

Loading

SethTisue Apr 21, 2021 •

edited

Loading

SethTisue commented Apr 21, 2021 •

edited

Loading