Skip to content

Forward port ClassTag caching from 2.12.x#9487

Merged
lrytz merged 1 commit intoscala:2.13.xfrom
retronym:class-tag-cache-port
Feb 8, 2021
Merged

Forward port ClassTag caching from 2.12.x#9487
lrytz merged 1 commit intoscala:2.13.xfrom
retronym:class-tag-cache-port

Conversation

@retronym
Copy link
Member

@retronym retronym commented Feb 5, 2021 •
edited
Loading

See #7879 and #9276

@scala-jenkins scala-jenkins added this to the 2.13.5 milestone Feb 5, 2021
@retronym retronym requested a review from lrytz February 5, 2021 05:38
@retronym retronym mentioned this pull request Feb 5, 2021
Merged
@lrytz
Copy link
Member

lrytz commented Feb 5, 2021 •
edited by SethTisue
Loading 

[error] /home/jenkins/workspace/scala-2.13.x-validate-main/src/library/scala/reflect/ClassTag.scala:132:77: match may not be exhaustive.
[error] It would fail on the following input: (x: Class[?] forSome x not in (TYPE, TYPE, TYPE, TYPE, TYPE, TYPE, TYPE, TYPE, TYPE))
[error]     private def primitiveClassTag[T](runtimeClass: Class[_]): ClassTag[_] = runtimeClass match {
[error]                                                                             ^

Okay okay scalac, we know you love types.

@retronym retronym force-pushed the class-tag-cache-port branch from 7bdc72d to 3f2203b Compare February 7, 2021 23:31
@lrytz lrytz force-pushed the class-tag-cache-port branch from 3f2203b to 998477d Compare February 8, 2021 15:08
@lrytz lrytz merged commit c75d80f into scala:2.13.x Feb 8, 2021
@retronym retronym mentioned this pull request Feb 15, 2021
Merged
hamzaremmal pushed a commit to hamzaremmal/scala3 that referenced this pull request May 2, 2025
@lrytz
Merge pull request scala/scala#9487 from retronym/class-tag-cache-port
0168a3c 
Forward port ClassTag caching from 2.12.x
hamzaremmal pushed a commit to scala/scala3 that referenced this pull request May 7, 2025
@lrytz
Merge pull request scala/scala#9487 from retronym/class-tag-cache-port
0ffdb91 
Forward port ClassTag caching from 2.12.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lrytz lrytz lrytz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.13.5

Development

Successfully merging this pull request may close these issues.

3 participants

@retronym @lrytz @scala-jenkins