Fix mimaReportBinaryIssues, doesn't run aggregate#9459
Merged
dwijnand merged 1 commit intoscala:2.13.xfrom Jan 27, 2021
Merged
Conversation
When you run a task in the shell, it uses the current project (normally root) and runs the tasks on the project and the project it aggregates. That's why "compile" compiles all and "test" tests all. But "testAll" is our custom thing, defined only on the root project, which refers to specific tasks to run. So while just "mimaReportBinaryIssues" does the right thing in the shell, it only checks root (which is a noop) when used in "testAll". So back to specifying both - but at least I still fixed unqualified "mimaReportBinaryIssues" from working in the shell.
SethTisue
approved these changes
Jan 27, 2021
dwijnand
added a commit
to regadas/scala
that referenced
this pull request
Feb 17, 2021
When you run a task in the shell, it uses the current project (normally root) and runs the tasks on the project and the project it aggregates. That's why "compile" compiles all and "test" tests all. But "testAll" is our custom thing, defined only on the root project, which refers to specific tasks to run. So while just "mimaReportBinaryIssues" does the right thing in the shell, it only checks root (which is a noop) when used in "testAll". So back to specifying both - but at least I still fixed unqualified "mimaReportBinaryIssues" from working in the shell. (cherry picked from commit 8e5951d) backport of scala#9459
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you run a task in the shell, it uses the current project (normally
root) and runs the tasks on the project and the project it aggregates.
That's why "compile" compiles all and "test" tests all. But "testAll"
is our custom thing, defined only on the root project, which refers to
specific tasks to run. So while just "mimaReportBinaryIssues" does the
right thing in the shell, it only checks root (which is a noop) when
used in "testAll". So back to specifying both - but at least I still
fixed unqualified "mimaReportBinaryIssues" from working in the shell.