[bport] Move & truncate the MiMa filters#9436
Merged
dwijnand merged 1 commit intoscala:2.12.xfrom Jan 14, 2021
Merged
Conversation
Backport cherry-pick of 710c91e. First of all, move the damn MiMa filters outside of build.sbt! In build.sbt it overpowers the rest of the build definition and also (it would seem) IntelliJ is better at handling Scala files than sbt files. Now, if a contributor needs to add filters, they can be advised to change "project/MimaFilters.scala". Secondly, bump the `mimaReferenceVersion` (which is used to define `mimaPreviousArtifacts`). Normal projects (without forwards compatibility) want to always bump that, so that new methods don't go missing. But for Scala it's less of a problem. However, it is because it means we have an always appended list of exclusions, and those might end up hiding real problems. While I was at it I fixed `mimaReportBinaryIssues` it can be called directly, by resetting `ThisBuild / mimaFailOnNoPrevious`.
SethTisue
reviewed
Jan 14, 2021
| import autoImport._ | ||
|
|
||
| override val globalSettings = Seq( | ||
| mimaReferenceVersion := Some("2.12.13"), |
Member
There was a problem hiding this comment.
ought to be in the release steps, I think
SethTisue
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport cherry-pick of 710c91e, aka #9328.
First of all, move the damn MiMa filters outside of build.sbt! In
build.sbt it overpowers the rest of the build definition and also (it
would seem) IntelliJ is better at handling Scala files than sbt files.
Now, if a contributor needs to add filters, they can be advised to
change "project/MimaFilters.scala".
Secondly, bump the
mimaReferenceVersion(which is used to definemimaPreviousArtifacts). Normal projects (without forwardscompatibility) want to always bump that, so that new methods don't go
missing. But for Scala it's less of a problem. However, it is because
it means we have an always appended list of exclusions, and those might
end up hiding real problems.
While I was at it I fixed
mimaReportBinaryIssuesit can be calleddirectly, by resetting
ThisBuild / mimaFailOnNoPrevious.