Skip to content

Re-STARR onto 2.13.4 & move+truncate the MiMa filters#9328

Merged
SethTisue merged 2 commits intoscala:2.13.xfrom
dwijnand:restarr
Nov 19, 2020
Merged

Re-STARR onto 2.13.4 & move+truncate the MiMa filters#9328
SethTisue merged 2 commits intoscala:2.13.xfrom
dwijnand:restarr

Conversation

@dwijnand
Copy link
Member

No description provided.

@scala-jenkins scala-jenkins added this to the 2.13.5 milestone Nov 19, 2020
@dwijnand dwijnand requested a review from SethTisue November 19, 2020 16:47
@dwijnand dwijnand changed the title Re-STARR onto 2.13.4 Re-STARR onto 2.13.4 & move+truncate the MiMa filters Nov 19, 2020
@SethTisue
Copy link
Member

LGTM, but not to Jenkins yet

First of all, move the damn MiMa filters outside of build.sbt!  In
build.sbt it overpowers the rest of the build definition and also (it
would seem) IntelliJ is better at handling Scala files than sbt files.

Now, if a contributor needs to add filters, they can be advised to
change "project/MimaFilters.scala".

Secondly, bump the `mimaReferenceVersion` (which is used to define
`mimaPreviousArtifacts`).  Normal projects (without forwards
compatibility) want to always bump that, so that new methods don't go
missing.  But for Scala it's less of a problem.  However, it is because
it means we have an always appended list of exclusions, and those might
end up hiding real problems.

While I was at it I fixed `mimaReportBinaryIssues` it can be called
directly, by resetting `ThisBuild / mimaFailOnNoPrevious`.
@SethTisue SethTisue added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Nov 19, 2020
@SethTisue SethTisue merged commit c758143 into scala:2.13.x Nov 19, 2020
@dwijnand dwijnand deleted the restarr branch November 19, 2020 23:34
@SethTisue
Copy link
Member

It was a mistake here that I didn't wait for Travis-CI, because it would have told us that the build fails because of warnings. I'm working on a PR with a fix.

@SethTisue
Copy link
Member

SethTisue commented Nov 20, 2020

hmm or maybe not a mistake, but just a semantic merge conflict with #9320 ?

well, in any case, PR soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal not resulting in user-visible changes (build changes, tests, internal cleanups)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants