Re-STARR onto 2.13.4 & move+truncate the MiMa filters#9328
Merged
SethTisue merged 2 commits intoscala:2.13.xfrom Nov 19, 2020
Merged
Re-STARR onto 2.13.4 & move+truncate the MiMa filters#9328SethTisue merged 2 commits intoscala:2.13.xfrom
SethTisue merged 2 commits intoscala:2.13.xfrom
Conversation
SethTisue
approved these changes
Nov 19, 2020
Member
|
LGTM, but not to Jenkins yet |
First of all, move the damn MiMa filters outside of build.sbt! In build.sbt it overpowers the rest of the build definition and also (it would seem) IntelliJ is better at handling Scala files than sbt files. Now, if a contributor needs to add filters, they can be advised to change "project/MimaFilters.scala". Secondly, bump the `mimaReferenceVersion` (which is used to define `mimaPreviousArtifacts`). Normal projects (without forwards compatibility) want to always bump that, so that new methods don't go missing. But for Scala it's less of a problem. However, it is because it means we have an always appended list of exclusions, and those might end up hiding real problems. While I was at it I fixed `mimaReportBinaryIssues` it can be called directly, by resetting `ThisBuild / mimaFailOnNoPrevious`.
Member
|
It was a mistake here that I didn't wait for Travis-CI, because it would have told us that the build fails because of warnings. I'm working on a PR with a fix. |
Member
|
hmm or maybe not a mistake, but just a semantic merge conflict with #9320 ? well, in any case, PR soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.