reword warning about equals and cooperative equality#9320
reword warning about equals and cooperative equality#9320SethTisue merged 1 commit intoscala:2.13.xfrom
equals and cooperative equality#9320Conversation
som-snytt
left a comment
There was a problem hiding this comment.
uses uncooperative equality
Uncooperative equality describes the state of democracy in the US.
| def typesString = "" + normalizeAll(qual.tpe.widen) + " and " + normalizeAll(other.tpe.widen) | ||
| def nonSensiblyEquals() = { | ||
| refchecksWarning(pos, s"comparing values of types $typesString using `${name.decode}` is unsafe due to cooperative equality; use `==` instead", WarningCategory.OtherNonCooperativeEquals) | ||
| refchecksWarning(pos, s"comparing values of types $typesString using `${name.decode}` unsafely bypasses cooperative equality; use `==` instead", WarningCategory.OtherNonCooperativeEquals) |
There was a problem hiding this comment.
Fine by me, but I guess my ideal is == become the symbolic alias of equals and we take down the patriarchy of so-called cooperative equality. A system that is closed to the participation of user-land extension, like UInt type by Spire, directly goes against the philosophy of growable language, which Scala is named after.
There was a problem hiding this comment.
Let's seize the moment to rename the language to Growa. Then you can say, Grow a UInt. And the t-shirt can read, Grow a Pair.
You read it right. The crony capitalism is corrupt. We need equal protection under eq law - https://eed3si9n.com/equal-protection-under-eq-law |
|
ah, now your efforts to radicalize Scala users through propagandistic warning messages are exposed! nice try, troublemaker!! 💣 |
…sage reword warning about `equals` and cooperative equality
…sage reword warning about `equals` and cooperative equality
this is a small adjustment to @eed3si9n's #8120
it's no big deal, but the old wording kind of made cooperative equality sound like what we need rescuing from, rather than what will rescue us