mutable.HashMap should override 'foreachEntry' to avoid tuple allocation#9425
Merged
Conversation
3 tasks
ijuma
approved these changes
Jan 8, 2021
ijuma
left a comment
Contributor
There was a problem hiding this comment.
Looks like this was somehow missed in the original commit.
3 tasks
ijuma
added a commit
to apache/kafka
that referenced
this pull request
Feb 23, 2021
This includes a fix from Chia-Ping that removes tuple allocations when `Map.forKeyValue` is used (scala/scala#9425) and support for JDK 16. Release notes: https://github.com/scala/scala/releases/tag/v2.13.5 Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
ijuma
added a commit
to apache/kafka
that referenced
this pull request
Feb 23, 2021
This includes a fix from Chia-Ping that removes tuple allocations when `Map.forKeyValue` is used (scala/scala#9425) and support for JDK 16. Release notes: https://github.com/scala/scala/releases/tag/v2.13.5 Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
May 2, 2025
mutable.HashMap should override 'foreachEntry' to avoid tuple allocation
hamzaremmal
pushed a commit
to scala/scala3
that referenced
this pull request
May 7, 2025
mutable.HashMap should override 'foreachEntry' to avoid tuple allocation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
foreachEntryis a hot method in our project and I noticed thatmutable.HashMapdoes not overrideforeachEntryso default implementation (Map#foreachEntry) creates manytuple2. We should do the improvement like b88a55d formutable.HashMap