Avoid use of binary incompatible super accessors in SortedMap/Set#9311
Merged
retronym merged 1 commit intoscala:2.12.xfrom Nov 16, 2020
Merged
Avoid use of binary incompatible super accessors in SortedMap/Set#9311retronym merged 1 commit intoscala:2.12.xfrom
retronym merged 1 commit intoscala:2.12.xfrom
Conversation
Member
|
This would have been the right thing to do initially, but aren't we creating a new problem if we merge it at this point? The 2.12.12 standard library defines an abstract If we merge this PR, user-defined subclasses compiled with 2.12.13 will no longer implement this super accessor and therefore not work correctly with a 2.12.12 standard library. |
Member
Author
|
Could we keep a call to super.equals on an unreachable code path?
|
8cb1df6 to
b5e6d54
Compare
lrytz
approved these changes
Nov 13, 2020
This comment has been minimized.
This comment has been minimized.
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
May 2, 2025
…t-bincompat Avoid use of binary incompatible super accessors in SortedMap/Set
hamzaremmal
pushed a commit
to scala/scala3
that referenced
this pull request
May 7, 2025
…t-bincompat Avoid use of binary incompatible super accessors in SortedMap/Set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.