Clean up warnings in library module#9235
Merged
diesalbla merged 4 commits intoscala:2.13.xfrom Oct 16, 2020
Merged
Conversation
Contributor
Author
|
I'm going to need to faff about with the ordering of the last 3 commits (and possibly squash 2 together) in order to get a clean history, I imagine Edit: oh look, I ended up needing to do that |
Contributor
|
This is the one Seth was looking forward to finishing up over a cold one? What a nice guy. He's probably off bumping an sbt version somewhere instead. |
Contributor
Author
|
I'm a fork/join pool, and I steal work ;) |
b5c2539 to
1d68315
Compare
1d68315 to
06a6d71
Compare
NthPortal
commented
Oct 9, 2020
06a6d71 to
96c6f46
Compare
diesalbla
approved these changes
Oct 10, 2020
96c6f46 to
8ad9aa8
Compare
Contributor
Author
|
new error needs fixing/suppressing due to #8120 |
Contributor
Author
|
Fix blocked by #9247 (or similar) |
Enable deprecation warnings for library module build and fix or suppress all deprecations in the library module.
Enable feature warnings for library module build and import feature flags where required in the library module.
8ad9aa8 to
5f2cb87
Compare
NthPortal
commented
Oct 16, 2020
Remove remaining -Xlint exclusions from library build and suppress locations where -Xlint raised warnings.
Add `fatalWarnings` boolean setting key to sbt build that adds the -Werror compile option to select modules. Enable `fatalWarnings` setting for library module build. Do not enable -Werror for the doc task.
5f2cb87 to
9c1da15
Compare
xuwei-k
reviewed
Jan 27, 2021
Comment on lines
-380
to
+381
| ) extends DefaultPromise[T]() with Callbacks[F] with Runnable with Batchable with OnCompleteRunnable { | ||
| final def this(xform: Int, f: _ => _, ec: ExecutionContext) = this(f.asInstanceOf[Any => Any], ec.prepare(), null, xform) | ||
| ) extends DefaultPromise[T]() with Callbacks[F] with Runnable with Batchable { | ||
| final def this(xform: Int, f: _ => _, ec: ExecutionContext) = |
Contributor
Author
There was a problem hiding this comment.
I'm concerned about how closely this is holding the standard library to implementation details
Member
There was a problem hiding this comment.
It's not, IMO. It's on Akka for relying on it.
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
May 2, 2025
…anup/PR Clean up warnings in library module
hamzaremmal
pushed a commit
to scala/scala3
that referenced
this pull request
May 7, 2025
…anup/PR Clean up warnings in library module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #8998