Fix regression in HashMap.{merge, ++}#8764
Merged
SethTisue merged 2 commits intoscala:2.12.xfrom Feb 29, 2020
Merged
Conversation
4ef8838 to
e659245
Compare
Member
Author
|
This now aligns with the corresponding code in
|
Member
|
The link in the commit message is wrong, it regressed in #8466. Let's fix it to avoid future confusion. |
Regressed in scala#8466
... in the way they construct the bitmap of the resulting node. No behaviour change.
0190312 to
cf3a6f1
Compare
szeiger
approved these changes
Feb 28, 2020
Contributor
szeiger
left a comment
There was a problem hiding this comment.
LGTM as far as I understand the code. Clearly allBits was wrong because it's always 0 at that point.
Member
|
community build run green except for unrelated failures (scala/scala-dev#673) |
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
May 2, 2025
…-regression
Fix regression in HashMap.{merge, ++}
hamzaremmal
pushed a commit
to scala/scala3
that referenced
this pull request
May 7, 2025
…-regression
Fix regression in HashMap.{merge, ++}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regressed in #8466
Fixes scala/scala-dev#672