Don't create a new TreeSet if there is no change to the underlying tree#8737
Merged
retronym merged 2 commits intoscala:2.12.xfrom Feb 26, 2020
Merged
Don't create a new TreeSet if there is no change to the underlying tree#8737retronym merged 2 commits intoscala:2.12.xfrom
retronym merged 2 commits intoscala:2.12.xfrom
Conversation
szeiger
reviewed
Feb 26, 2020
| /** A factory to create empty sets of the same type of keys. | ||
| */ | ||
| override def empty = TreeSet.empty | ||
| override def empty = newSet(null) |
Contributor
There was a problem hiding this comment.
Why would you want to create a new instance every time instead of reusing the TreeSet.empty singleton?
Contributor
Author
There was a problem hiding this comment.
TreeSet isn't a singleton, it has the implicit ordering parameter so creates a new instance
newSet will not create a new Set if this is already empty, and that is the best that we can do as I see it
def empty[A](implicit ordering: Ordering[A]) = new TreeSet[A]
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
May 2, 2025
Dont create a new TreeSet if there is no change to the underlying tree
hamzaremmal
pushed a commit
to scala/scala3
that referenced
this pull request
May 7, 2025
Dont create a new TreeSet if there is no change to the underlying tree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.